Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

Christoph Feck christoph at maxiom.de
Thu Sep 25 18:56:28 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120361/#review67445
-----------------------------------------------------------

Ship it!


Commit it without the comment and the blank line before it, please. This is not a code block that needs to be documented separately. We need to change the properties of freshly created objects in many places, and only separate them for bigger functional blocks.

- Christoph Feck


On Sept. 25, 2014, 12:36 p.m., Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120361/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2014, 12:36 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> see title and screenshots
> 
> 
> Diffs
> -----
> 
>   src/kpagedialog.cpp b28873b 
> 
> Diff: https://git.reviewboard.kde.org/r/120361/diff/
> 
> 
> Testing
> -------
> 
> Breeze and fusion
> 
> 
> File Attachments
> ----------------
> 
> before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/062cbcab-b184-4ed4-9cec-a94c503c0fa7__config-after.png
> after
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/25/a8b7f663-7225-4f60-806b-833113583e67__config-after1.png
> 
> 
> Thanks,
> 
> Hugo Pereira Da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140925/25483b01/attachment.html>


More information about the Kde-frameworks-devel mailing list