Review Request 120138: kshorturifilter : Treat "///..." as "/"

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/#review67084
-----------------------------------------------------------

Ship it!



src/urifilters/shorturi/kshorturifilter.cpp
<https://git.reviewboard.kde.org/r/120138/#comment46818>

    doesn't this warn about comparing signed with unsigned? cmd.length() is signed in Qt.
    
    -> remove "unsigned" before firstNonSlash



src/urifilters/shorturi/kshorturifilter.cpp
<https://git.reviewboard.kde.org/r/120138/#comment46819>

    doesn't this warn about comparing signed with unsigned? cmd.length() is signed in Qt.
    
    -> remove "unsigned" before firstNonSlash



src/urifilters/shorturi/kshorturifilter.cpp
<https://git.reviewboard.kde.org/r/120138/#comment46820>

    add space between '-' and '1'


- David Faure


On Sept. 19, 2014, 1:47 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120138/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 1:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> "///..." should produce `QUrl("file:///")` not `QUrl("file://")`
> 
> 
> Diffs
> -----
> 
>   autotests/kurifiltertest.cpp b84dcd0 
>   src/urifilters/shorturi/kshorturifilter.cpp 00668d9 
> 
> Diff: https://git.reviewboard.kde.org/r/120138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140920/f98f3965/attachment-0001.html>