Review Request 120283: make KConfigLoader more predictable by exposing a getter to KConfig's OpenFlags

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120283/
-----------------------------------------------------------

(Updated Sept. 19, 2014, 2:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
-------

When opening a KSharedConfig, the OpenFlags must match to share the underlying config object. Otherwise a new KConfig is created and the benefit of using KSharedConfig is lost. This was triggering subtle bugs with the use of KConfigLoader in plasmashell.

This patchset adddress that issue by exposing the OpenFlags used to open a KConfig.

Another approach would be to add another KSharedConfig::openConfig() which takes a KConfig object and uses that in its search for a matching pointer object, and then use that version of openConfig in KSharedConfig


Diffs
-----

  src/core/kconfig.h d7d4b7df8f33e33a389527d47d02fc844b74aed3 
  src/core/kconfig.cpp c6dec43641611bf14c5eb04d3007dd9016bcb3c8 
  src/gui/kconfigloader.cpp 52ac6d17b427a6eb8519699f642759b7ae672b81 

Diff: https://git.reviewboard.kde.org/r/120283/diff/


Testing
-------

Used KConfigLoader in startup config of plasmashell and settings are now propagated correctly from the shell scripting to the config loader objects.


Thanks,

Aaron J. Seigo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140919/0d8a3e38/attachment.html>