Review Request 119777: Make KFontUtils::adaptFontSize be a bit more exact

Albert Astals Cid aacid at kde.org
Thu Sep 18 21:43:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119777/
-----------------------------------------------------------

(Updated Sept. 18, 2014, 9:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kguiaddons


Description
-------

Not all fonts are linear in drawn size against their point size, the old code assumes so and simply guesses the next font size taking into account the pointSize we drawn, the geometry we got and the geometry we want. The new code is a bit slower but will make sure that we get better pointSize results in non linear fonts.

This is a continuation from https://git.reviewboard.kde.org/r/114907/


Diffs
-----

  src/fonts/kfontutils.cpp 3a80039 

Diff: https://git.reviewboard.kde.org/r/119777/diff/


Testing
-------

Blinken still works. Font sizes are similar.

I did code an autotest to try situations like 9 and 10 like David suggested, problem is that i can't upload that test since it depends on the font, etc so that would be extremely unstable.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140918/0737b0b5/attachment.html>


More information about the Kde-frameworks-devel mailing list