Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

[Dominik Haumann]

> On Sept. 14, 2014, 6:33 p.m., Dominik Haumann wrote:
> > All in all, the patch looks good, but it misses emitting the signals hideAnimationFinished() and showAnimationFinished().
> > Why? Without your patch, you can be *sure* that after calling show() or animatedShow() the signal showAnimationFinished() will eventually be emitted.
> > With the current version of your patch, this is not true anymore. For instance, KatePart relies on these signals to work.
> > 
> > I'd be fine with committing this to KF5, but I would suggest to not backport to 4.x.
> 
> Fabio D'Urso wrote:
>     Well, iirc I've read that KatePart internally queues messages and waits for the completion signal before showing the next message, therefore it never interrupts running animations (which is what I'm fixing), or does it?
>     
>     About the 4.x backport, we're agreed: I'm targeting kf5 only (4.x doesn't even have `is{Hide,Show}AnimationRunning` and `{hide,show}AnimationFinished`)

Yes, I swapped both signals. Well ok, if you do not add these two lines, then please document that in the header file for the two signals hideAnimationFinished(), along the lines:
@note Calling animatedShow() while the hide animation is running (see hideAnimationRunning()) will @e not emit this signals.
Same for showAnimationFinished().

I'd prefer to have a 3rd opinion about this from other developers what they'd expect.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120160/#review66489
-----------------------------------------------------------


On Sept. 18, 2014, 10:40 a.m., Fabio D'Urso wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120160/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 10:40 a.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Aurélien Gâteau.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> Hi, I've found that if you call animatedShow() immediatly after animatedHide(), without waiting for the hide animation to finish first, the hide animation goes on and, in the end, the message widget becomes hidden.
> 
> The attached patch adds checks in animatedShow and animatedHide so that, if an opposite animation is currently running, they just reverse it.
> 
> 
> Diffs
> -----
> 
>   autotests/kmessagewidgetautotest.h 062e2b3 
>   autotests/kmessagewidgetautotest.cpp f46bab0 
>   src/kmessagewidget.cpp bc7ba32 
>   tests/kmessagewidgettest.cpp f621b5a 
> 
> Diff: https://git.reviewboard.kde.org/r/120160/diff/
> 
> 
> Testing
> -------
> 
> I've added buttons to invoke animatedShow and animatedHide in tests/kmessagewidget.cpp and used them to test the behavior.
> 
> I've also added an autotest that checks the final height and isVisible() value, both after single animatedShow/animatedHide calls and after animatedShow+animatedHide and animatedHide+animatedShow.
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140918/e01c7dbb/attachment.html>