Review Request 119607: Support for ".hidden" files

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review66777
-----------------------------------------------------------


Thanks for the patch. A few comments:

Is there any sort of spec or reference implementation for ".hidden" files? Are they supposed to support wildcards, for instance?

Something else, it would be good to add a unittest to autotests/kdirlistertest.cpp (or autotests/kdirmodeltest.cpp).


src/core/kcoredirlister.h
<https://git.reviewboard.kde.org/r/119607/#comment46570>

    Why is this added to the public API?
    It seems to be only used internally.
    
    --> make it a file-static method in kcoredirlister.cpp



src/core/kcoredirlister.cpp
<https://git.reviewboard.kde.org/r/119607/#comment46572>

    Declare where used first, no need to put it here.



src/core/kcoredirlister.cpp
<https://git.reviewboard.kde.org/r/119607/#comment46571>

    not needed, the QFile destructor does it



src/core/kfileitem.h
<https://git.reviewboard.kde.org/r/119607/#comment46573>

    @since 5.3


- David Faure


On Sept. 14, 2014, 7:32 p.m., Bruno Nova wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119607/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 7:32 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 64740 and 246260
>     https://bugs.kde.org/show_bug.cgi?id=64740
>     https://bugs.kde.org/show_bug.cgi?id=246260
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This adds support for *.hidden* files to KDE.
> 
> When listing a directory, the files/folders listed in the *.hidden* file will be hidden, unless the user has chosen to show hidden files.
> 
> This patch was initially based on the patch provided by Mark in Bug #246260.
> 
> 
> Diffs
> -----
> 
>   src/core/kcoredirlister.h e6ba2ac 
>   src/core/kcoredirlister.cpp a31d629 
>   src/core/kfileitem.h bebc241 
>   src/core/kfileitem.cpp 74dc069 
> 
> Diff: https://git.reviewboard.kde.org/r/119607/diff/
> 
> 
> Testing
> -------
> 
> Built and tested the patch in Project Neon.
> Dolphin was still using KDE4/Qt4 version of the library, so I only tested using the desktop folder widget, and "folder desktop".
> It worked correctly when I pointed it to "~" and "~/Desktop" (I added ".hidden" there).
> However, it didn't work when I pointed it to the "Desktop folder" (the default option, not the custom location "~/Desktop").
> More testing is required.
> 
> The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget and detailed/tree view in Dolphin).
> It wasn't an intensive test, though.
> 
> 
> Thanks,
> 
> Bruno Nova
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140917/45c99f9b/attachment.html>