Review Request 120228: Support Gerrit in the fancy header style
Albert Astals Cid
aacid at kde.org
Tue Sep 16 07:14:29 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120228/#review66639
-----------------------------------------------------------
It adds a new string, please ask kde-i18n-doc about an exception if everyone else agreees 4.14 is the right branch to commit (i do think it makes sense there)
- Albert Astals Cid
On set. 16, 2014, 7:10 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120228/
> -----------------------------------------------------------
>
> (Updated set. 16, 2014, 7:10 a.m.)
>
>
> Review request for KDE Frameworks and KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> If the email is from Gerrit the following information is added to the
> header:
> * message type
> * url to change
> * change-id as link test for the url
>
> ----
> I'm not sure which is the right branch for such a change to go in.
>
>
> Diffs
> -----
>
> messageviewer/header/fancyheaderstyle.cpp f58f07bda9b750aed30795644bdba5175f5edd56
> messageviewer/header/headerstrategy_p.h 14951ea792ee13e468ff5a047c13dc94b78d6bc2
>
> Diff: https://git.reviewboard.kde.org/r/120228/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Example for a new change
> https://git.reviewboard.kde.org/media/uploaded/files/2014/09/16/60cdd1c0-d911-49a7-b184-cbb424d45ae1__gerrit-fancy-.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140916/c8d185b1/attachment.html>
More information about the Kde-frameworks-devel
mailing list