Review Request 120213: Add support for protocols to NETWinInfo

[Thomas Lübking]

> On Sept. 15, 2014, 8:34 nachm., Thomas Lübking wrote:
> > src/netwm.cpp, line 4630
> > <https://git.reviewboard.kde.org/r/120213/diff/1/?file=312330#file312330line4630>
> >
> >     Tarzan speech. Consider:
> >     - TakeFocusProtocol
> >     - Protocol::TakeFocus
> 
> Martin Gräßlin wrote:
>     we are (to my understanding) not allowed to use the enum class from C++11. As netwm_def.h is shared between the implementations I cannot even argument with "but it's not compiled on Windows". So I'll switch to the TakeFocusProtocol approach.

You could use a nested namespace, but i'm absolutely fine with TakeFocusProtocol.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120213/#review66605
-----------------------------------------------------------


On Sept. 16, 2014, 5:55 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120213/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 5:55 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> NETWinInfo is now able to read all known protocols set on WM_PROTOCOLS
> property and provides the set protocols as flags.
> 
> So far the following protocols are supported:
> * WM_TAKE_FOCUS (ICCCM 4.1.2.7)
> * WM_DELETE_WINDOW (ICCCM 4.1.2.7)
> * _NET_WM_SYNC_REQUEST (EWMH)
> * _NET_WM_PING (EWMH)
> * _NET_WM_CONTEXT_HELP (KDE specific extension to EWMH)
> 
> CHANGELOG: NETWinInfo provides convenient wrapper for WM_PROTOCOLS.
> 
> 
> Diffs
> -----
> 
>   autotests/netwininfotestclient.cpp 7d941f4b32a546c8284ab81995f594cd9e69617e 
>   src/netwm.h 436ad2fd449b48a36d3bb15754f7c8c64f52c8dd 
>   src/netwm.cpp 1431cf6bae605050e2e86f7ca60357ddb7736d32 
>   src/netwm_def.h 12abfff03af5b81a60ec03a5366b6ff0b95d35d0 
>   src/netwm_p.h a586450211846af464c9014f586e14b0e808cd75 
> 
> Diff: https://git.reviewboard.kde.org/r/120213/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140916/678b77ad/attachment.html>