Review Request 120196: Find-Module to detect libgit2
Alex Merry
alex.merry at kde.org
Mon Sep 15 19:07:56 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/#review66594
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Sept. 15, 2014, 6:56 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120196/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 6:56 p.m.)
>
>
> Review request for KDE Frameworks and Alex Merry.
>
>
> Repository: extra-cmake-modules
>
>
> Description
> -------
>
> Add a find module that allows to detect libgit2.
> Will be used by KTextEditor & Kate.
> Will remove the copy in KTextEditor after this is merged.
>
>
> Diffs
> -----
>
> docs/find-module/FindLibGit2.rst PRE-CREATION
> find-modules/FindLibGit2.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120196/diff/
>
>
> Testing
> -------
>
> Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140915/9048daee/attachment.html>
More information about the Kde-frameworks-devel
mailing list