Review Request 120196: Find-Module to detect libgit2

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120196/#review66593
-----------------------------------------------------------


Yep, I think the name change is sensible.


find-modules/FindLibGit2.cmake
<https://git.reviewboard.kde.org/r/120196/#comment46410>

    Whitespace



find-modules/FindLibGit2.cmake
<https://git.reviewboard.kde.org/r/120196/#comment46413>

    Remove this comment (I know it's in other modules, but the comment isn't really true, especially once you remove VERSION_STRING).



find-modules/FindLibGit2.cmake
<https://git.reviewboard.kde.org/r/120196/#comment46412>

    Don't need this one in a completely new module.


- Alex Merry


On Sept. 15, 2014, 6:30 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120196/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 6:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> Add a find module that allows to detect libgit2.
> Will be used by KTextEditor & Kate.
> Will remove the copy in KTextEditor after this is merged.
> 
> 
> Diffs
> -----
> 
>   docs/find-module/FindLibGit2.rst PRE-CREATION 
>   find-modules/FindLibGit2.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120196/diff/
> 
> 
> Testing
> -------
> 
> Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140915/6a4afdba/attachment.html>