Review Request 120217: KWindowInfo::state can map urgency to NET::DemandsAttention

Martin Gräßlin mgraesslin at kde.org
Mon Sep 15 13:29:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120217/
-----------------------------------------------------------

Review request for KDE Frameworks and kwin.


Repository: kwindowsystem


Description
-------

If WM2Urgency is passed to the ctor of KWindowInfo, ::state() checks
the urgency state is set and adds NET::DemandsAttention. This allows
to easily check whether the window demands attention either through
EWMH or ICCCM.

The change does not affect existing code as one has to explicitly
pass WM2Urgency and this one is new in 5.3, too.

This change only affects platform X11.

CHANGELOG: KWindowInfo::state can map urgency to NET::DemandsAttention


Diffs
-----

  autotests/kwindowinfox11test.cpp 3ff6a49447a99d9afdabe6c96361b276083de525 
  src/kwindowinfo.h b00e115f293231b661934d20e97be4d186f679de 
  src/kwindowinfo_x11.cpp 2a32692a0f664d6a9884e6d1a1209e88e02944ec 

Diff: https://git.reviewboard.kde.org/r/120217/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140915/65136c7e/attachment.html>


More information about the Kde-frameworks-devel mailing list