Review Request 120165: Add support for input hint in NETWinInfo

Martin Gräßlin mgraesslin at kde.org
Mon Sep 15 07:15:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120165/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 7:15 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
-------

The Input Hint is part of WM_HINTS property which is already processed
for WM2GroupLeader and WM2Urgency.

The default for input hint is true. ICCCM suggests to assume convenient
values for all fields of WM_HINTS property if a window is mapped wihtout
one. KWin sets this value to true, so the sane convenient value for the
input field seems to be true.


Diffs
-----

  autotests/netwininfotestclient.cpp 160f7599f3fba9398029db3be5841fe78bbf7cf0 
  src/netwm.h 0c89dc7385e2542e6e21da55985fd8b926fb3e37 
  src/netwm.cpp a0a2faeeb1dea432a7c2d1e72800de3cf6cb6d2a 
  src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 
  src/netwm_p.h 2e4659e53adb3975d69f0bfffb88d26c0148edd6 

Diff: https://git.reviewboard.kde.org/r/120165/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140915/b9782ba9/attachment.html>


More information about the Kde-frameworks-devel mailing list