Review Request 120139: kill warning
Andreas Hartmetz
ahartmetz at gmail.com
Sun Sep 14 01:05:01 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120139/#review66446
-----------------------------------------------------------
It looks like the warning is indeed misguided, but it is not clear that just ignoring that an assumption was violated is the right thing to do.
- Andreas Hartmetz
On Sept. 11, 2014, 10:48 vorm., Sune Vuorela wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120139/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 10:48 vorm.)
>
>
> Review request for KDE Frameworks, Andreas Hartmetz and Stephen Kelly.
>
>
> Repository: kitemviews
>
>
> Description
> -------
>
> The warninng is even triggered by from internal KWidgetItemDelegatePrivate, so seems to be wrong
>
> Try out the kwidgetitemdelegate test application
>
>
> Diffs
> -----
>
> src/kwidgetitemdelegatepool.cpp d61802e
>
> Diff: https://git.reviewboard.kde.org/r/120139/diff/
>
>
> Testing
> -------
>
> Warning not printed.
>
>
> Thanks,
>
> Sune Vuorela
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140914/f7f9145e/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list