Review Request 120186: Make the encoding prober data tables const.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120186/#review66415
-----------------------------------------------------------

Ship it!


Cool, looks like a no-brained to me. Could we also wrap these things in anonymous namespaces to give them file-local linkage?

- Milian Wolff


On Sept. 13, 2014, 4:02 p.m., Volker Krause wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120186/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2014, 4:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcodecs
> 
> 
> Description
> -------
> 
> This reduces the size of the .data section from 4232 bytes to just 8, thus
> reducing per-process memory overhead.
> 
> These files are based on Mozilla code, which seems to contain the same
> change by now.
> 
> 
> Diffs
> -----
> 
>   src/probers/nsEscSM.cpp 0927ecf18fbf27e6ec3450c9ed5aa37482c953c6 
>   src/probers/nsLatin1Prober.cpp ea164149291f64bec0498c28ec04ff1cf098de4c 
>   src/probers/nsMBCSSM.cpp 3913b901820baa5722b5a6906cdf4009493cc266 
>   src/probers/nsPkgInt.h 2a3b5742fd3f5158e4dc6f523e7dfd5ef7f7ad22 
>   src/probers/nsSBCharSetProber.h 30bd8baee984ad661e42f0785d8276adad0a97b3 
>   src/probers/LangHungarianModel.cpp 82add0e7c8bd43e4bf56f60ce8cd381dd0a2889c 
>   src/probers/LangThaiModel.cpp 72c44b30978e7b15d593c8c7a8b6a20b4407a942 
>   src/probers/nsCodingStateMachine.h 6eb00189fbc25dbd40e68692065e2542c88aa156 
>   src/probers/LangCyrillicModel.cpp cff257b4f3df5f8835ce1e5108684f82f21c5340 
>   src/probers/LangGreekModel.cpp 5791314324776b1a7e13eec567861e6993aa0239 
>   src/probers/LangHebrewModel.cpp 30483ce2de2521eea0025b77ab1ea17bbf4f2b77 
>   src/probers/LangBulgarianModel.cpp 322d2e6e7e4dd5d049c0212da823b12cbbc48b91 
> 
> Diff: https://git.reviewboard.kde.org/r/120186/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140913/c7205276/attachment.html>