Review Request 120173: Add unicode emoticons to Glass theme

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120173/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: kemoticons


Description
-------

KEmoticons can't correctly parse unicode emoticons. They mostly show as little squares or (some of them) as little black and white emoticons, but they aren't parsed to the emoticons in the Glass theme.

This patch adds unicode emoticons to the emoticons.xml file so that they are translated to the theme images.

The problem is that the available themes don't have enough emoticons and some information is lost in the translation, but that can only be fixed with a complete theme that someone has to make. Fortunately, some people are already working on it [1] :-D .

The codes of the unicode characters that I have added can be seen with 'less' for review. Otherwise, I don't know how it can be reviewed.

[1] https://forum.kde.org/viewtopic.php?f=285&t=122712


Diffs
-----

  themes/Glass/emoticons.xml dad55e2 

Diff: https://git.reviewboard.kde.org/r/120173/diff/


Testing
-------

I tested with kemoticonstest, in the test folder.

It doesn't work with Qt 5.2. It works with Qt 5.4. I haven't tested with Qt 5.3.


Thanks,

David Gil Oliva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140912/468988ed/attachment.html>