Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo

[Martin Gräßlin]

> On Sept. 12, 2014, 3:26 p.m., Thomas Lübking wrote:
> > src/netwm.cpp, line 4562
> > <https://git.reviewboard.kde.org/r/120158/diff/1/?file=311733#file311733line4562>
> >
> >     #include <xcb/xcb_icccm.h> is not an option?

nope, distros still have problems with it (see workaround we have in KWin).


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120158/#review66343
-----------------------------------------------------------


On Sept. 12, 2014, 11:48 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120158/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 11:48 a.m.)
> 
> 
> Review request for KDE Frameworks and kwin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> -------
> 
> UrgencyHint is part of WM_HINTS property which is already processed
> for WM2GroupLeader.
> 
> 
> Diffs
> -----
> 
>   autotests/netwininfotestclient.cpp 160f7599f3fba9398029db3be5841fe78bbf7cf0 
>   src/netwm.h 0c89dc7385e2542e6e21da55985fd8b926fb3e37 
>   src/netwm.cpp a0a2faeeb1dea432a7c2d1e72800de3cf6cb6d2a 
>   src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 
>   src/netwm_p.h 2e4659e53adb3975d69f0bfffb88d26c0148edd6 
> 
> Diff: https://git.reviewboard.kde.org/r/120158/diff/
> 
> 
> Testing
> -------
> 
> see added unit test
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140912/ecd46e17/attachment.html>