Review Request 120138: kshorturifilter : Treat "///..." as "/"

[Arjun Ak]

> On Sept. 12, 2014, 2:48 a.m., David Faure wrote:
> > src/urifilters/shorturi/kshorturifilter.cpp, line 133
> > <https://git.reviewboard.kde.org/r/120138/diff/1/?file=311470#file311470line133>
> >
> >     This looks slow. It will go through a very long path, counting the number of slashes, even though it could stop at the first non-'/' character and give up.
> >     
> >     Doing it fast requires a small while loop.

Is it really necessary? In most cases the user might enter atmost two or three slashes.


- Arjun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120138/#review66289
-----------------------------------------------------------


On Sept. 11, 2014, 2:20 p.m., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120138/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 2:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> "///..." should produce `QUrl("file:///")` not `QUrl("file://")`
> 
> 
> Diffs
> -----
> 
>   autotests/kurifiltertest.cpp b84dcd0 
>   src/urifilters/shorturi/kshorturifilter.cpp 00668d9 
> 
> Diff: https://git.reviewboard.kde.org/r/120138/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140912/5dd089f1/attachment-0001.html>