Review Request 120144: Equal entries imply existing

[Jan-Marek Glogowski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120144/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 1:07 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kio


Description
-------

Equal entries imply exist


Diffs
-----

  src/ioslaves/file/file_unix.cpp bd16ce33e188b6613b3fdc8d712095144808bf94 

Diff: https://git.reviewboard.kde.org/r/120144/diff/


Testing
-------

The equal file error should take precedence over the existing directory error, as this implies exist.
    
This actually prevents a data loss on case-insensitive file systems like CIFS, where renaming a directory from 'Test' to 'test' actually removes the single directory (both have the same inode).
    
This was just tested and fixed in our KDE4 kfile handler and konqueror, which have the same problem (KDE 4.12 on Kubuntu 12.04).


Thanks,

Jan-Marek Glogowski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140912/a3368a24/attachment.html>