Review Request 120131: Fix encoding issue in places dialog.

Maarten De Meyer de.meyer.maarten at gmail.com
Thu Sep 11 16:11:16 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120131/
-----------------------------------------------------------

(Updated Sept. 11, 2014, 4:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Bugs: 337642
    https://bugs.kde.org/show_bug.cgi?id=337642


Repository: kbookmarks


Description
-------

toLatin1 gives encoding issues in KIO placesview. Example from the bug report is "Romário" -> "Rom?rio"
I'm not sure if this is the correct solution? Why did this work in the past? And why was the cast to ascii and latin1 needed?


Diffs
-----

  src/kbookmark.cpp 9543120 

Diff: https://git.reviewboard.kde.org/r/120131/diff/


Testing
-------

Tested with placesview from kwrite and dolphin.
Any other code where kbookmarks is used that I should check for regressions?


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140911/703b980b/attachment.html>


More information about the Kde-frameworks-devel mailing list