Review Request 120142: correct documentation for overlays parameter

Christoph Feck christoph at maxiom.de
Thu Sep 11 14:36:26 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120142/#review66270
-----------------------------------------------------------

Ship it!


Ship It!

- Christoph Feck


On Sept. 11, 2014, 2:02 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120142/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 2:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> -------
> 
> correct documentation for overlays parameter
> 
> The current documentation is incorrect, as no 'emblem' prefix is added
> to the overlay name. Also there is no mention how the emblems are placed.
> Instead of giving a complete definition, reference the drawOverlays
> method.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
> 
> 
> Diffs
> -----
> 
>   src/kiconloader.h 46d3017e703c38bfa4da9e5cb721b0c596a26815 
> 
> Diff: https://git.reviewboard.kde.org/r/120142/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140911/ab0509b7/attachment.html>


More information about the Kde-frameworks-devel mailing list