Review Request 120132: correct documentation for overlays parameter

[Luigi Toscano]

> On Set. 10, 2014, 11:31 p.m., Luigi Toscano wrote:
> > I guess this is about frameworks branch. If yes, please ignore it, as it has been split into the several framework repositories; check if the issue applies in the separate KIconThemes framework.
> 
> Stefan Brüns wrote:
>     patch applies also to kiconthemes framework

So please open a review for kiconthemes and discard this one, because the frameworks branch of kdelibs is not developed anymore (of course!) after the split. It is needed to allow proper history through git grafting.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120132/#review66195
-----------------------------------------------------------


On Set. 10, 2014, 11:24 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120132/
> -----------------------------------------------------------
> 
> (Updated Set. 10, 2014, 11:24 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The current documentation is incorrect, as no 'emblem' prefix is added
> to the overlay name. Also there is no mention how the emblems are placed.
> Instead of giving a complete definition, reference the drawOverlays
> method.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de
> 
> 
> Diffs
> -----
> 
>   tier3/kiconthemes/src/kiconloader.h a32734564786ab1bd7920ce13339f7f8713d9260 
> 
> Diff: https://git.reviewboard.kde.org/r/120132/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140911/d5415d47/attachment.html>