Review Request 120071: QUrl::fromUserInput in kfilewidget

[David Faure]

> On Sept. 5, 2014, 10:14 p.m., David Faure wrote:
> > Ship It!

I reworked this code today, to fix other issues (fromUserInput is wrong for relative paths, which affected at least other parts of the code). Can you check that it's still working for you? Thanks.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120071/#review65867
-----------------------------------------------------------


On Sept. 6, 2014, 1:44 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120071/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 1:44 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 337557
>     https://bugs.kde.org/show_bug.cgi?id=337557
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KUrl porting error. KFileDialog cannot open url from user input because it has no scheme.
> 
> 
> Diffs
> -----
> 
>   src/filewidgets/kfilewidget.cpp 10c6120 
> 
> Diff: https://git.reviewboard.kde.org/r/120071/diff/
> 
> 
> Testing
> -------
> 
> Now I can open absolute url's with KFileDialog
> Local and remote files work.
> 
> Not tested: KDEPlatformFileDialog 
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140909/4315fb28/attachment.html>