Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

[Kai Uwe Broulik]

> On Sept. 7, 2014, 1:48 nachm., David Edmundson wrote:
> > I've just added kdeframeworks to the review group in case they have comments.

Meh. Q_GADGET expands to add a static const QMetaObject staticMetaObject and that's a BIC, right?


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120092/#review65987
-----------------------------------------------------------


On Sept. 7, 2014, 1:49 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120092/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 1:49 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> Thanks to the awesome David, I discovered Q_GADGET and it allows us to expose the Duration stuff in KDeclarative without needing to turn it into a QObject
> 
> 
> Diffs
> -----
> 
>   src/lib/util/kformat.h 7a6a418 
>   src/lib/util/kformat.cpp d62240e 
> 
> Diff: https://git.reviewboard.kde.org/r/120092/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140909/c6d5a7e7/attachment.html>