Review Request 120096: replace static arrays with dynamic size with QVector
Milian Wolff
mail at milianw.de
Tue Sep 9 10:19:18 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120096/#review66110
-----------------------------------------------------------
Ship it!
looks good from my side, but david should have a look at it as well I guess
- Milian Wolff
On Sept. 9, 2014, 9:14 a.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120096/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2014, 9:14 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: karchive
>
>
> Description
> -------
>
> on windows static arrays can only be initialized with a const
>
>
> Diffs
> -----
>
> src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7
>
> Diff: https://git.reviewboard.kde.org/r/120096/diff/
>
>
> Testing
> -------
>
> windows
>
>
> Thanks,
>
> Patrick Spendrin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140909/deedcf4c/attachment.html>
More information about the Kde-frameworks-devel
mailing list