Review Request 119958: Fix thumbnails for mimetype groups.

[Maarten De Meyer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119958/
-----------------------------------------------------------

(Updated Sept. 8, 2014, 10:15 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Filter out 'ThumbCreator' values
Also fix protocols

I don't think adding the comment 2 times is necessary. But if you prefer I'll add it before committing.
Thanks.


Repository: kio


Description
-------

Fix a regression in PreviewJob. This one was hard to find :)

KService::mimeTypes cannot handle mimetype groups. ex: text/*
Use KService::serviceTypes instead and ignore the first item which is
always type 'ThumbCreator'

This is the quick and easy solution. I could also add support for mimetype groups to KService::mimeTypes. (so that it return all mimetypes in a group) Not sure what the best solution is. Are groups only used in thumbnailer files?


Diffs (updated)
-----

  src/widgets/previewjob.cpp 55a3fb7 

Diff: https://git.reviewboard.kde.org/r/119958/diff/


Testing
-------

I'm porting a thumbnailer to frameworks 5. Before nothing happend, now I see thumbnails.


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140908/ff458d27/attachment.html>