Review Request 120096: replace static arrays with dynamic size with QVector

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120096/#review66046
-----------------------------------------------------------



src/k7zip.cpp
<https://git.reviewboard.kde.org/r/120096/#comment46117>

    This must be resize, otherwise your codecID will be "empty". The `codecID[i]` below probably will assert in debug mode as well now.



src/k7zip.cpp
<https://git.reviewboard.kde.org/r/120096/#comment46118>

    this could be a QByteArray directly, and again resize it, not reserve.



src/k7zip.cpp
<https://git.reviewboard.kde.org/r/120096/#comment46119>

    this would be obsoleted if you use a QByteArray above directly


- Milian Wolff


On Sept. 7, 2014, 3:20 p.m., Patrick Spendrin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120096/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2014, 3:20 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> on windows static arrays can only be initialized with a const
> 
> 
> Diffs
> -----
> 
>   src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 
> 
> Diff: https://git.reviewboard.kde.org/r/120096/diff/
> 
> 
> Testing
> -------
> 
> windows
> 
> 
> Thanks,
> 
> Patrick Spendrin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140908/8df417e0/attachment.html>