Review Request 120024: Prevent some false positive critical warnings for KStandardActions

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120024/
-----------------------------------------------------------

(Updated Sept. 7, 2014, 6:03 nachm.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Repository: kxmlgui


Description
-------

In combination with https://git.reviewboard.kde.org/r/120025/, please read that one first.

This part of the patch does:
* make KActionCollection::setDefaultShortcuts() invokable per QMetaObject::invokeMethod, so KStandardAction::create(...) can access it
* make sure that setDefaultShortcuts is also called for KStandardActions created in the non-default-name addAction variant
* add a new constructor to KHelpMenu to allow passing an KActionCollection in, so all standardactions can be created from the beginning as items in the actioncollection, including setup with setDefaultShortcuts

Follow-up for KHelpMenu in KParts is https://git.reviewboard.kde.org/r/120026/


Diffs
-----

  src/kactioncollection.h 5dbc3c2 
  src/kactioncollection.cpp 6c7af0f 
  src/khelpmenu.h df820f2 
  src/khelpmenu.cpp 53397cc 
  src/kxmlguifactory.cpp c4ad97b 
  src/kxmlguiwindow.cpp bd89279 

Diff: https://git.reviewboard.kde.org/r/120024/diff/


Testing
-------

With this and the other patches, I can see no more of those warnings for standard actions, both KWrite and Okteta.
Also all unit tests still work.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140907/efab5eec/attachment.html>