Review Request 120093: Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message + use same method to output available methods

Christoph Cullmann cullmann at kde.org
Sun Sep 7 13:29:18 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120093/
-----------------------------------------------------------

(Updated Sept. 7, 2014, 1:29 p.m.)


Review request for KDE Frameworks and David Faure.


Summary (updated)
-----------------

Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message + use same method to output available methods


Repository: kcoreaddons


Description (updated)
-------

Guard the 'KDirWatchPrivate::addEntry: Added File...' with same guard as the removeEntry output.
Guard available methods with same trick, will allow use in non-debug build of that output.


Diffs (updated)
-----

  src/lib/io/kdirwatch.cpp 7abb32a 

Diff: https://git.reviewboard.kde.org/r/120093/diff/


Testing (updated)
-------

Tested with Kate, removed the super verbose "Added File..." output for any opened file.
Available methods are gone in output, too.


Thanks,

Christoph Cullmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140907/9928fe0c/attachment.html>


More information about the Kde-frameworks-devel mailing list