Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

Jonathan Riddell jr at jriddell.org
Sun Sep 7 09:21:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119977/
-----------------------------------------------------------

(Updated Sept. 7, 2014, 9:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
-------

Mark setProgramIconName() as deprecated, it did not do anything since
kcoreaddons no longer uses QtGui so it can not set the icon.

BUG: 337938


Diffs
-----

  src/lib/kaboutdata.h 2d8bd5645150a57739e94f9f71b112b20ec0e01f 
  src/lib/kaboutdata.cpp 5ad81de814c123f50b17bb542331459e15649f4b 

Diff: https://git.reviewboard.kde.org/r/119977/diff/


Testing
-------

compiled a program made with kapptemplate 4.14.1 which uses this function, successfully gives a warning during compile


Thanks,

Jonathan Riddell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140907/1f5f4a8f/attachment.html>


More information about the Kde-frameworks-devel mailing list