Review Request 119975: KDBusService shouldn't crash upon bad application name

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119975/#review65864
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Aug. 28, 2014, 3:57 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119975/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2014, 3:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdbusaddons
> 
> 
> Description
> -------
> 
> If the application name has a '-', Qt asserts. Instead of going there, remove the '-' and output a warning so the replacement is noticed and fixable.
> 
> 
> Diffs
> -----
> 
>   src/kdbusservice.cpp a9b7cc8 
> 
> Diff: https://git.reviewboard.kde.org/r/119975/diff/
> 
> 
> Testing
> -------
> 
> Ran tests, reproduced with an application.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140905/2eea8e17/attachment.html>