Review Request 120058: Move imagethumbnailer away from KDE4Support

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120058/#review65817
-----------------------------------------------------------



thumbnail/imagecreator.h
<https://git.reviewboard.kde.org/r/120058/#comment45989>

    Q_DECL_OVERRIDE maybe? 
    Given that you have done other cleanups as well, touching one line more shouldn't be a problem.



thumbnail/imagecreator.cpp
<https://git.reviewboard.kde.org/r/120058/#comment45988>

    Wrong indentation!


- Emmanuel Pescosta


On Sept. 4, 2014, 5:42 p.m., Maarten De Meyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120058/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 5:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> Remove unused includes and we don't need KDE4Support anymore.
> I alse replaced some tabs with spaces.
> 
> 
> Diffs
> -----
> 
>   thumbnail/CMakeLists.txt bd40c0e 
>   thumbnail/imagecreator.h d06c9fa 
>   thumbnail/imagecreator.cpp dd5ffe2 
> 
> Diff: https://git.reviewboard.kde.org/r/120058/diff/
> 
> 
> Testing
> -------
> 
> Removed my thumbnail cache and created new thumbnails. Works both from dolphin and from plasma.
> 
> 
> Thanks,
> 
> Maarten De Meyer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140905/767e3e4c/attachment.html>