Review Request 120049: KDirNotify: Use QUrl::toStringList

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120049/#review65776
-----------------------------------------------------------

Ship it!


If you want to go really crazy, you could try this as well:
emitSignal(QLatin1String("FilesChanged"), QVariantList() << QUrl::toStringList(fileList)); (note the lack of QVariant())

Make sure that works though :)

- Mark Gaiser


On sep 3, 2014, 4:30 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120049/
> -----------------------------------------------------------
> 
> (Updated sep 3, 2014, 4:30 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> Instead of a custom function. QUrl::toStringList reserves the size of the new list before hand.
> 
> 
> Diffs
> -----
> 
>   src/core/kdirnotify.cpp 14f4c9c 
> 
> Diff: https://git.reviewboard.kde.org/r/120049/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140903/99f97438/attachment.html>