Review Request 120023: Fix crash in unit test when run with ASAN

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120023/#review65622
-----------------------------------------------------------

Ship it!


I agree about using C++ style casts or C++ style constructors rather than C casts. I don't necessarily agree about hardcoding 8 being wrong - this is the implementation of a binary file format, if the spec says "and the next 8 bytes are..." then the code should say 8 too.

Anyhow, fix is good to go in, let's not nitpick.

- David Faure


On Aug. 31, 2014, 2:46 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120023/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2014, 2:46 p.m.)
> 
> 
> Review request for KDE Frameworks, Mario Bensi and Mathieu Tarral.
> 
> 
> Repository: karchive
> 
> 
> Description
> -------
> 
> Without this patch when running karchivetest with asan I get http://paste.kde.org/p3unh9jzk
> 
> Discovered in conjunction with Mathieu Tarral
> 
> 
> Diffs
> -----
> 
>   src/k7zip.cpp 4a88453 
> 
> Diff: https://git.reviewboard.kde.org/r/120023/diff/
> 
> 
> Testing
> -------
> 
> Test now passes
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20140901/1ec8aaf6/attachment.html>