Review Request 120909: in kio_smb: Set inode/directory mimetype for folders
David Faure
faure at kde.org
Fri Oct 31 08:52:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120909/#review69572
-----------------------------------------------------------
Hmm, not sure which change in KFileItem you're referring to. But maybe this is the change from KMimeType (which used a mode_t argument) to QMimeType (which doesn't). We could add some logic in KFileItem to preserve behavior compat for kioslaves if you want.
- David Faure
On Oct. 30, 2014, 10:42 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120909/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 10:42 p.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> Set inode/directory mimetype for folders
>
>
> Diffs
> -----
>
> smb/kio_smb_browse.cpp 67e2fa0
>
> Diff: https://git.reviewboard.kde.org/r/120909/diff/
>
>
> Testing
> -------
>
> Previously (kde4) KFileItem was doing an extra effort into figuring out the miemtype for remotes url but now it is not (at least not by default).
>
> Since we already know that the item is a directory we can set the mimetype already, saving roundtrips and making samba kioslave show folder icons again (and faster since we save a stat).
>
> Would be nice if somebody from frameworks (kio) could confirm that the situation regarding mimetypes in frameworks have changed.
>
>
> Thanks,
>
> Àlex Fiestas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141031/5992c445/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list