Review Request 120888: add a new KNotification::Event with icon name

Christoph Feck christoph at maxiom.de
Thu Oct 30 12:25:41 UTC 2014



> On Oct. 30, 2014, 12:18 p.m., Christoph Feck wrote:
> > This seems to introduce a source-incompatible change, see build failure in kruler/frameworks: http://paste.opensuse.org/68026650

oops, already fixed


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120888/#review69522
-----------------------------------------------------------


On Oct. 29, 2014, 1:56 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120888/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> for
> https://bugs.kde.org/show_bug.cgi?id=321688
> 
> 
> Diffs
> -----
> 
>   src/knotification.h 815d195 
>   src/knotification.cpp 8421eaf 
> 
> Diff: https://git.reviewboard.kde.org/r/120888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141030/35f97730/attachment.html>


More information about the Kde-frameworks-devel mailing list