Review Request 120888: add a new KNotification::Event with icon name

Martin Klapetek martin.klapetek at gmail.com
Wed Oct 29 13:52:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120888/#review69447
-----------------------------------------------------------

Ship it!



src/knotification.h
<https://git.reviewboard.kde.org/r/120888/#comment48578>

    "This will emit a standard event with the possibility of setting an icon by icon name"
    
    So it's clear where is the difference from the others ^_-


- Martin Klapetek


On Oct. 29, 2014, 2:47 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120888/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 2:47 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> -------
> 
> for
> https://bugs.kde.org/show_bug.cgi?id=321688
> 
> 
> Diffs
> -----
> 
>   src/knotification.h 815d195 
>   src/knotification.cpp 8421eaf 
> 
> Diff: https://git.reviewboard.kde.org/r/120888/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141029/dacb3211/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list