Review Request 120887: add custom icons to KNotification

[Martin Klapetek]

Wait, I got a comment but can't post it from the phone, will be back in
about an hour



--



Sent from my Nokia N9



On 29.10.2014 12:57 Kai Uwe Broulik wrote:
  This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120887/

Ship it!

Ship It!


- Kai Uwe Broulik

On Oktober 29th, 2014, 11:49 vorm. UTC, Marco Martin wrote:
  Review request for KDE Frameworks.
By Marco Martin.

*Updated Okt. 29, 2014, 11:49 vorm.*
 *Repository: * knotifications
Description

There are some cases in which applications need a custom icon for a
particular notification, and used to work around sending the pixmap of
the icon instead (of which you don't know if will end up the right
size)

this adds an icon property to knotification, if none set, the one set
in the notifyrc is used as before

  Diffs

   - src/knotification.h (456e84b)
   - src/knotification.cpp (0ea13cb)
   - src/notifybypopup.cpp (c7add40)

View Diff <https://git.reviewboard.kde.org/r/120887/diff/>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141029/5b430787/attachment.html>