Review Request 120887: add custom icons to KNotification

Marco Martin notmart at gmail.com
Wed Oct 29 11:27:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120887/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: knotifications


Description
-------

There are some cases in which applications need a custom icon for a particular notification, and used to work around sending the pixmap of the icon instead (of which you don't know if will end up the right size)

this adds an icon property to knotification, if none set, the one set in the notifyrc is used as before


Diffs
-----

  src/knotification.cpp 0ea13cb 
  src/notifybypopup.cpp c7add40 
  src/knotification.h 456e84b 

Diff: https://git.reviewboard.kde.org/r/120887/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141029/5b868692/attachment.html>


More information about the Kde-frameworks-devel mailing list