Review Request 120886: Show script execution prompt only if asked to

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Oct 29 11:08:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120886/#review69406
-----------------------------------------------------------



src/widgets/krun.h
<https://git.reviewboard.kde.org/r/120886/#comment48510>

    since 5.4



src/widgets/krun.h
<https://git.reviewboard.kde.org/r/120886/#comment48509>

    Better name instead of b? showPrompt maybe?


- Emmanuel Pescosta


On Oct. 29, 2014, 12:01 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120886/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2014, 12:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> KRun shouldn't show script/desktop execution prompts by default, but only if asked to by the application, since KRun is also used by launchers, whose sole purpose is to execute programs.
> 
> 
> Diffs
> -----
> 
>   src/widgets/krun.h 545c3a9 
>   src/widgets/krun.cpp af5e8dc 
> 
> Diff: https://git.reviewboard.kde.org/r/120886/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141029/00dda643/attachment.html>


More information about the Kde-frameworks-devel mailing list