Review Request 120813: Set shortcuts via invoked meta method

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120813/
-----------------------------------------------------------

(Updated Oct. 28, 2014, 11:14 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Daniel Laidig.


Repository: kwidgetsaddons


Description
-------

While porting KCharSelect application to KF5, I noticed that KCharSelect widget class still uses QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().

This adds code to invoke setDefaultShortcuts() via QMetaObject - same as for addAction() - so that KCharSelect widget class does not need to depend on kxmlgui.

For the KActionCollection patch see https://git.reviewboard.kde.org/r/120812/


Diffs
-----

  src/kcharselect.cpp 0d345a4 

Diff: https://git.reviewboard.kde.org/r/120813/diff/


Testing
-------

None.


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141028/e4e615d6/attachment.html>