Review Request 120833: Handle absolute paths without extension in KPluginLoader::findPlugin()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120833/#review69357
-----------------------------------------------------------


This should be done in Qt, IMHO. The docu (which I added in 418890e07) says "We recommend omitting the file's suffix in the file name" without specifying that this would only work for relative paths.

- David Faure


On Oct. 27, 2014, 9:51 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120833/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2014, 9:51 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Sebastian Kügler.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> -------
> 
> This means that e.g. KPluginLoader::findPlugin("/usr/lib/plugins/foo")
> can now return "/usr/lib/plugins/foo.so" instead of an empty string.
> 
> Should this be done in Qt instead?
> 
> 
> Diffs
> -----
> 
>   autotests/kpluginloadertest.cpp 3ded0ebca2e0fd20e09bf6e4eca152d13ac11f46 
>   src/lib/plugin/kpluginloader.cpp 802ef843bca4526cc9a4ee6780e8125453786b12 
> 
> Diff: https://git.reviewboard.kde.org/r/120833/diff/
> 
> 
> Testing
> -------
> 
> Unit test passes
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141028/84567941/attachment.html>