Review Request 120854: KPassivePopup - Set default hide delay
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Oct 28 16:16:24 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120854/#review69303
-----------------------------------------------------------
Should maybe be "delay < 0"?
Either way, +1.
- Aleix Pol Gonzalez
On Oct. 28, 2014, 4:14 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120854/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 4:14 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Bugs: 340238
> https://bugs.kde.org/show_bug.cgi?id=340238
>
>
> Repository: knotifications
>
>
> Description
> -------
>
> If delay "-1" is passed, it means "server default", but in KPassivePopup the default was never set.
>
> Fixes bug 340238.
>
>
> Diffs
> -----
>
> src/kpassivepopup.cpp d253898
>
> Diff: https://git.reviewboard.kde.org/r/120854/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141028/b151ae5c/attachment.html>
More information about the Kde-frameworks-devel
mailing list