Review Request 120720: Open X-DocPath entries from Help button kcmshell5 in KHelpcenter

David Faure faure at kde.org
Mon Oct 27 22:52:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120720/#review69226
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On Oct. 22, 2014, 1:38 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120720/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 1:38 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> -------
> 
> For X-DocPath entries like foo/index.html or kcontrol/foo/index.html QUrl::fromUserInput() 
> returns "http://foo/index.html" or "http://kcontrol/foo/index.html"
> 
> Therefore without the patch always a Browser is launched with "http://foo/index.html"
> 
> 
> Diffs
> -----
> 
>   src/kcmultidialog.cpp 19d312d 
> 
> Diff: https://git.reviewboard.kde.org/r/120720/diff/
> 
> 
> Testing
> -------
> 
> Started a few kcms via kcmshell5, clicked the Help button and the docbooks are displayed in KHelpcenter now.
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141027/210194bc/attachment.html>


More information about the Kde-frameworks-devel mailing list