Review Request 120586: Fix KPluginSelector not adding non .desktop file plugins

[Alexander Richardson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120586/
-----------------------------------------------------------

(Updated Oct. 27, 2014, 5:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcmutils


Description
-------

KPluginSelector always assumed those plugins had already been added to
the list because it only compares KPluginInfo::entryPath() for equality
which returns an empty string if the plugin metadata was loaded directly
from the shared library. Therefore as soon as one plugin with the
metadata embedded into the library had been loaded all others would
compare equal to that.

Is this the correct fix or should KPluginInfo::entryPath() be changed?


Diffs
-----

  src/kpluginselector_p.h 43648114224f476ea3c30f6bd255206f9c415d21 

Diff: https://git.reviewboard.kde.org/r/120586/diff/


Testing
-------


Thanks,

Alexander Richardson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141027/eabec43b/attachment-0001.html>