Review Request 120813: Set shortcuts via invoked meta method
Christoph Feck
christoph at maxiom.de
Sun Oct 26 14:26:26 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120813/
-----------------------------------------------------------
(Updated Oct. 26, 2014, 2:26 p.m.)
Review request for KDE Frameworks, David Faure and Daniel Laidig.
Repository: kwidgetsaddons
Description
-------
While porting KCharSelect application to KF5, I noticed that KCharSelect widget class still uses QAction::setShortcuts() instead of KActionCollection::setDefaultShortcuts().
This adds code to invoke setDefaultShortcuts() via QMetaObject - same as for addAction() - so that KCharSelect widget class does not need to depend on kxmlgui.
For the KActionCollection patch see https://git.reviewboard.kde.org/r/120812/
Diffs
-----
src/kcharselect.cpp 0d345a4
Diff: https://git.reviewboard.kde.org/r/120813/diff/
Testing
-------
None.
Thanks,
Christoph Feck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141026/a75f45c4/attachment.html>
More information about the Kde-frameworks-devel
mailing list