Review Request 120666: Get user's permission before executing scripts or desktop files

[Emmanuel Pescosta]

> On Oct. 23, 2014, 1:14 p.m., Emmanuel Pescosta wrote:
> > src/widgets/krun.cpp, line 1013
> > <https://git.reviewboard.kde.org/r/120666/diff/2/?file=321616#file321616line1013>
> >
> >     Any reason why using show instead of exec? Exec would avoid the rather complex and error-prone code path.
> >     
> >     IMHO we should prefer a blocking dialog in this case, because it asks the user for permission.
> 
> Arjun AK wrote:
>     >IMHO we should prefer a blocking dialog in this case, because it asks the user for permission.
>     
>     faure: Are you okay with this?
> 
> Frank Reininghaus wrote:
>     Note that you have to be *extremely* careful when calling exec(), which runs a nested event loop. Anything can happen inside such a loop, including quitting the application. See https://git.reviewboard.kde.org/r/118858/ and the links in the comments there fore more information.
>     
>     If you replace show() by exec() in your patch, you might get a crash in the line
>     
>     m_dialogNotYetShown = false;
>     
>     if the application quits inside the nested event loop.
> 
> Emmanuel Pescosta wrote:
>     > m_dialogNotYetShown = false;
>     
>     This variable won't be needed anymore. Only the result of exec() is needed.
> 
> David Faure wrote:
>     Please please keep the non-modal dialog.
>     
>     Modal dialogs are very annoying - and even more so when called from plasma: suddenly your whole taskbar and desktop is unusable, just because somewhere there's a modal dialog.

> and even more so when called from plasma: suddenly your whole taskbar and desktop is unusable

This is indeed really bad.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120666/#review68990
-----------------------------------------------------------


On Oct. 22, 2014, 6:10 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120666/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2014, 6:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> -------
> 
> This patch makes KIO show a dialog box asking the user what to do (either open it using a text editor or execute it) when he clicks on a script or a desktop file.
> 
> See also: https://git.reviewboard.kde.org/r/120171/
> 
> 
> Diffs
> -----
> 
>   src/widgets/CMakeLists.txt 4060cdf 
>   src/widgets/executablefileopendialog.h PRE-CREATION 
>   src/widgets/executablefileopendialog.cpp PRE-CREATION 
>   src/widgets/krun.cpp 6ac42da 
>   src/widgets/krun_p.h 69e2e98 
> 
> Diff: https://git.reviewboard.kde.org/r/120666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141024/20be69a6/attachment.html>