Review Request 119505: Instance our onw QFileDialog instead of using getExistingDirectoryUrl
Àlex Fiestas
afiestas at kde.org
Thu Oct 23 20:00:57 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119505/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 8 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks.
Repository: kio
Description
-------
getExistingDirectoryUrl only works for local files so we have to implement it on our own for now.
As for Qt, QFileDialog::getExistingDirectoryUrl calls QUrl.toLocalFile, if we remove that, further down the code path _qt_get_directory is called which checks that the file exists but since Qt is not able to talk all our kios (for example smb) it will return false.
So at the moment we are forced to implement it ourselves.
Diffs
-----
src/widgets/kurlrequester.cpp cf0b0c7
Diff: https://git.reviewboard.kde.org/r/119505/diff/
Testing
-------
Thanks,
Àlex Fiestas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141023/8fc2e332/attachment.html>
More information about the Kde-frameworks-devel
mailing list