Review Request 120728: Install public header for KNotifyPlugin

Martin Klapetek martin.klapetek at gmail.com
Wed Oct 22 17:33:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120728/
-----------------------------------------------------------

Review request for KDE Frameworks.


Repository: knotifications


Description
-------

...to allow custom KNotification plugins. This class is being exported since ever, but the public header was missing.

Also, I'd like to rename this class to KNotificationPlugin rather than KNotifyPlugin as there is no KNotify anymore, but renaming already exported class is not allowed in frameworks as that would break BC, right?


Diffs
-----

  src/CMakeLists.txt 5b109c8 

Diff: https://git.reviewboard.kde.org/r/120728/diff/


Testing
-------


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141022/4df36b9f/attachment.html>


More information about the Kde-frameworks-devel mailing list