Review Request 120665: Extract new function KMimeTypeEditor::editMimeType from KMimeTypeChooser.

Christoph Feck christoph at maxiom.de
Mon Oct 20 12:57:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120665/#review68759
-----------------------------------------------------------

Ship it!


Ship It!

- Christoph Feck


On Oct. 19, 2014, 10:26 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120665/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2014, 10:26 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> This will be useful for kio's KPropertiesDialog, and replace KonqOperations::editMimeType,
> so it will also be used by DolphinPart, FSView, and KonqPopupMenu.
> 
> 
> Diffs
> -----
> 
>   src/kmimetypeeditor.cpp PRE-CREATION 
>   src/CMakeLists.txt d5d3db0279fe749f25c641829f72baabd6f56a46 
>   src/kmimetypechooser.cpp cb576a2afe6595c132f4ec868f8a0c0309e1439e 
>   src/kmimetypeeditor.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120665/diff/
> 
> 
> Testing
> -------
> 
> Launched kmimetypechoosertest, selected mimetype, clicked on "Edit...", worked.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141020/2c96a1e5/attachment.html>


More information about the Kde-frameworks-devel mailing list