Review Request 119607: Support for ".hidden" files
David Faure
faure at kde.org
Sat Oct 18 10:02:39 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119607/#review68653
-----------------------------------------------------------
The last patch says "I have not tested this yet" - has it been tested meanwhile? Let's not let this rot completely :-)
- David Faure
On Sept. 18, 2014, 10:06 a.m., Bruno Nova wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119607/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2014, 10:06 a.m.)
>
>
> Review request for KDE Frameworks and David Faure.
>
>
> Bugs: 64740 and 246260
> https://bugs.kde.org/show_bug.cgi?id=64740
> https://bugs.kde.org/show_bug.cgi?id=246260
>
>
> Repository: kio
>
>
> Description
> -------
>
> This adds support for *.hidden* files to KDE.
>
> When listing a directory, the files/folders listed in the *.hidden* file will be hidden, unless the user has chosen to show hidden files.
>
> This patch was initially based on the patch provided by Mark in Bug #246260.
>
>
> Diffs
> -----
>
> src/core/kcoredirlister.h e6ba2ac
> src/core/kcoredirlister.cpp a31d629
> src/core/kfileitem.h bebc241
> src/core/kfileitem.cpp 74dc069
>
> Diff: https://git.reviewboard.kde.org/r/119607/diff/
>
>
> Testing
> -------
>
> Built and tested the patch in Project Neon.
> Dolphin was still using KDE4/Qt4 version of the library, so I only tested using the desktop folder widget, and "folder desktop".
> It worked correctly when I pointed it to "~" and "~/Desktop" (I added ".hidden" there).
> However, it didn't work when I pointed it to the "Desktop folder" (the default option, not the custom location "~/Desktop").
> More testing is required.
>
> The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu 14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder widget and detailed/tree view in Dolphin).
> It wasn't an intensive test, though.
>
>
> Thanks,
>
> Bruno Nova
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20141018/965d7567/attachment.html>
More information about the Kde-frameworks-devel
mailing list